chia7712 commented on code in PR #757:
URL: https://github.com/apache/yunikorn-core/pull/757#discussion_r1570649442


##########
pkg/webservice/handlers_test.go:
##########
@@ -2602,3 +2607,82 @@ func NewResponseRecorderWithDeadline() 
*ResponseRecorderWithDeadline {
                ResponseRecorder: httptest.NewRecorder(),
        }
 }
+
+func TestCompressGetQueueApplicationAPI(t *testing.T) {

Review Comment:
   As we apply the compression to all restful APIs by changing the `webservice` 
directly, it seems we should add test for `webservice` instead of verifying all 
APIs here. For example: we can modify `newRouter` to make it accept custom 
routes, and then we write some dumb routes in testing to check the gzip 
compression.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to