targetoee commented on code in PR #757:
URL: https://github.com/apache/yunikorn-core/pull/757#discussion_r1540375757


##########
pkg/webservice/handlers.go:
##########
@@ -1216,3 +1227,40 @@ func getStream(w http.ResponseWriter, r *http.Request) {
                }
        }
 }
+
+func checkHeader(h http.Header, key string, value string) bool {

Review Comment:
   Thanks to everyone for all the advice. I have got some questions about what 
@wilfred-s said. 
   In the provided example, the compress handler would be wrapped within the 
logging handler. So we first see which API is being called, and then decide 
whether to use the gzip handler, since we haven't decided to compress all APIs 
yet? Is there any misunderstanding?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to