targetoee commented on code in PR #757:
URL: https://github.com/apache/yunikorn-core/pull/757#discussion_r1581720402
##########
pkg/webservice/handlers_test.go:
##########
@@ -2602,3 +2607,82 @@ func NewResponseRecorderWithDeadline()
*ResponseRecorderWithDeadline {
ResponseRecorder: httptest.NewRecorder(),
}
}
+
+func TestCompressGetQueueApplicationAPI(t *testing.T) {
+ schedulerContext, err := scheduler.NewClusterContext(rmID, policyGroup,
[]byte(configDefault))
+ assert.NilError(t, err, "Error when creating cluster context.")
+ partitionName := common.GetNormalizedPartitionName("default", rmID)
+ part := schedulerContext.GetPartition(partitionName)
+ _ = addApp(t, "app-1", part, "root.default", false)
+ _ = addApp(t, "app-2", part, "root.default", false)
+ _ = addApp(t, "app-3", part, "root.default", false)
+
+ m := NewWebApp(schedulerContext, nil)
+ m.StartWebApp()
+ defer func() {
+ err = m.StopWebApp()
+ assert.NilError(t, err, "Error when closing webapp service.")
+ }()
+
+ err = common.WaitFor(500*time.Millisecond, 2*time.Second, func() bool {
+ conn, connErr := net.DialTimeout("tcp",
net.JoinHostPort("127.0.0.1", "9080"), time.Second)
+ if connErr == nil {
+ defer conn.Close()
+ return true
+ }
+ return false
+ })
+ assert.NilError(t, err, "Ｗebapp failed to start in 2 seconds.")
+
+ u := &url.URL{
+ Host: "localhost:9080",
+ Scheme: "http",
+ Path:
"/ws/v1/partition/default/queue/root.default/applications",
+ }
+
+ // request without gzip compression
+ var buf io.ReadWriter
+ req, err := http.NewRequest("GET", u.String(), buf)
+ assert.NilError(t, err, "Create new http request failed.")
+ req.Header.Set("Accept", "application/json")
+ // prevent http.DefaultClient from automatically adding gzip header
+ req.Header.Set("Accept-Encoding", "deflate")
+ resp, err := http.DefaultClient.Do(req)
+ assert.NilError(t, err, "Request failed to send.")
+ data, err := io.ReadAll(resp.Body)
+ assert.NilError(t, err, "Failed when reading data.")
+ defer resp.Body.Close()
+ var originalResp []*dao.ApplicationDAOInfo
+ err = json.Unmarshal(data, &originalResp)
+ assert.NilError(t, err, unmarshalError)
+
+ // request with gzip compression enabled
+ req.Header.Set("Accept-Encoding", "gzip")
+ resp2, err := http.DefaultClient.Do(req)
+ assert.NilError(t, err, "Request failed to send.")
+ gzipReader, err := gzip.NewReader(resp2.Body)
+ assert.NilError(t, err, "Failed to create gzip reader.")
+ data2, err := io.ReadAll(gzipReader)
+ assert.NilError(t, err, "Failed when reading data.")
Review Comment:
Done
##########
pkg/webservice/handlers_test.go:
##########
@@ -2602,3 +2607,82 @@ func NewResponseRecorderWithDeadline()
*ResponseRecorderWithDeadline {
ResponseRecorder: httptest.NewRecorder(),
}
}
+
+func TestCompressGetQueueApplicationAPI(t *testing.T) {
+ schedulerContext, err := scheduler.NewClusterContext(rmID, policyGroup,
[]byte(configDefault))
+ assert.NilError(t, err, "Error when creating cluster context.")
+ partitionName := common.GetNormalizedPartitionName("default", rmID)
+ part := schedulerContext.GetPartition(partitionName)
+ _ = addApp(t, "app-1", part, "root.default", false)
+ _ = addApp(t, "app-2", part, "root.default", false)
+ _ = addApp(t, "app-3", part, "root.default", false)
+
+ m := NewWebApp(schedulerContext, nil)
+ m.StartWebApp()
+ defer func() {
+ err = m.StopWebApp()
+ assert.NilError(t, err, "Error when closing webapp service.")
+ }()
+
+ err = common.WaitFor(500*time.Millisecond, 2*time.Second, func() bool {
+ conn, connErr := net.DialTimeout("tcp",
net.JoinHostPort("127.0.0.1", "9080"), time.Second)
+ if connErr == nil {
+ defer conn.Close()
+ return true
+ }
+ return false
+ })
+ assert.NilError(t, err, "Ｗebapp failed to start in 2 seconds.")
+
+ u := &url.URL{
+ Host: "localhost:9080",
+ Scheme: "http",
+ Path:
"/ws/v1/partition/default/queue/root.default/applications",
+ }
+
+ // request without gzip compression
+ var buf io.ReadWriter
+ req, err := http.NewRequest("GET", u.String(), buf)
+ assert.NilError(t, err, "Create new http request failed.")
+ req.Header.Set("Accept", "application/json")
+ // prevent http.DefaultClient from automatically adding gzip header
+ req.Header.Set("Accept-Encoding", "deflate")
+ resp, err := http.DefaultClient.Do(req)
+ assert.NilError(t, err, "Request failed to send.")
+ data, err := io.ReadAll(resp.Body)
+ assert.NilError(t, err, "Failed when reading data.")
+ defer resp.Body.Close()
+ var originalResp []*dao.ApplicationDAOInfo
+ err = json.Unmarshal(data, &originalResp)
+ assert.NilError(t, err, unmarshalError)
+
+ // request with gzip compression enabled
+ req.Header.Set("Accept-Encoding", "gzip")
+ resp2, err := http.DefaultClient.Do(req)
+ assert.NilError(t, err, "Request failed to send.")
+ gzipReader, err := gzip.NewReader(resp2.Body)
+ assert.NilError(t, err, "Failed to create gzip reader.")
+ data2, err := io.ReadAll(gzipReader)
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
