craigcondit commented on code in PR #757:
URL: https://github.com/apache/yunikorn-core/pull/757#discussion_r1674679553
##########
pkg/webservice/webservice.go:
##########
@@ -43,7 +46,7 @@ type WebService struct {
func newRouter() *httprouter.Router {
router := httprouter.New()
for _, webRoute := range webRoutes {
- handler := loggingHandler(webRoute.HandlerFunc, webRoute.Name)
+ handler := gzipHandler(loggingHandler(webRoute.HandlerFunc,
webRoute.Name))
Review Comment:
I don't think we should unconditionally GZIP every response, only those that
might be large. I'd suggest adding a "Compress" boolean to the route object in
routes.go and use that to determine whether to add the gzip handler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
