craigcondit commented on code in PR #757:
URL: https://github.com/apache/yunikorn-core/pull/757#discussion_r1674680890
##########
pkg/webservice/webservice.go:
##########
@@ -43,7 +46,7 @@ type WebService struct {
func newRouter() *httprouter.Router {
router := httprouter.New()
for _, webRoute := range webRoutes {
- handler := loggingHandler(webRoute.HandlerFunc, webRoute.Name)
+ handler := gzipHandler(loggingHandler(webRoute.HandlerFunc,
webRoute.Name))
Review Comment:
For example, none of the /debug routes should have it (many of those
generate binary data which is not compressible, and/or are simple text that
wouldn't benefit). It should probably not be on anything that typically results
in < 10 KB of data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
