chia7712 commented on code in PR #850:
URL: https://github.com/apache/yunikorn-k8shim/pull/850#discussion_r1619523246
##########
pkg/client/apifactory.go:
##########
@@ -171,29 +171,34 @@ func (s *APIFactory) AddEventHandler(handlers
*ResourceEventHandlers) {
func (s *APIFactory) addEventHandlers(
handlerType Type, handler cache.ResourceEventHandler, resyncPeriod
time.Duration) {
+ var err error
switch handlerType {
case PodInformerHandlers:
- s.GetAPIs().PodInformer.Informer().
+ _, err = s.GetAPIs().PodInformer.Informer().
AddEventHandlerWithResyncPeriod(handler, resyncPeriod)
case NodeInformerHandlers:
- s.GetAPIs().NodeInformer.Informer().
+ _, err = s.GetAPIs().NodeInformer.Informer().
AddEventHandlerWithResyncPeriod(handler, resyncPeriod)
case ConfigMapInformerHandlers:
- s.GetAPIs().ConfigMapInformer.Informer().
+ _, err = s.GetAPIs().ConfigMapInformer.Informer().
AddEventHandlerWithResyncPeriod(handler, resyncPeriod)
case StorageInformerHandlers:
- s.GetAPIs().StorageInformer.Informer().
+ _, err = s.GetAPIs().StorageInformer.Informer().
AddEventHandlerWithResyncPeriod(handler, resyncPeriod)
case PVInformerHandlers:
- s.GetAPIs().PVInformer.Informer().
+ _, err = s.GetAPIs().PVInformer.Informer().
AddEventHandlerWithResyncPeriod(handler, resyncPeriod)
case PVCInformerHandlers:
- s.GetAPIs().PVCInformer.Informer().
+ _, err = s.GetAPIs().PVCInformer.Informer().
AddEventHandlerWithResyncPeriod(handler, resyncPeriod)
case PriorityClassInformerHandlers:
- s.GetAPIs().PriorityClassInformer.Informer().
+ _, err = s.GetAPIs().PriorityClassInformer.Informer().
AddEventHandlerWithResyncPeriod(handler, resyncPeriod)
}
+
+ if err != nil {
Review Comment:
If we fail to add handler, the initialization should be viewed as "failure"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
