pbacsko commented on code in PR #850:
URL: https://github.com/apache/yunikorn-k8shim/pull/850#discussion_r1620211343
##########
pkg/client/apifactory.go:
##########
@@ -166,34 +167,42 @@ func (s *APIFactory) AddEventHandler(handlers
*ResourceEventHandlers) {
}
log.Log(log.ShimClient).Info("registering event handler",
zap.Stringer("type", handlers.Type))
- s.addEventHandlers(handlers.Type, h, 0)
+ if err := s.addEventHandlers(handlers.Type, h, 0); err != nil {
+ log.Log(log.AdmissionConf).Fatal("Failed to initialize event
handlers", zap.Error(err))
Review Comment:
Do we want to exit here? Or delegate to the code in `main.go()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
