pbacsko commented on code in PR #891:
URL: https://github.com/apache/yunikorn-core/pull/891#discussion_r1638388150
##########
pkg/common/configs/configvalidator.go:
##########
@@ -69,7 +69,11 @@ var DefaultPreemptionDelay = 30 * time.Second
// A queue can be a username with the dot replaced. Most systems allow a 32
character user name.
// The queue name must thus allow for at least that length with the
replacement of dots.
-var QueueNameRegExp = regexp.MustCompile(`^[a-zA-Z0-9_-]{1,64}$`)
+var QueueNameRegExp = regexp.MustCompile(`^[a-zA-Z0-9_:#/@-]{1,64}$`)
+
+// A queue can be a username with the dot replaced. Most systems allow a 32
character user name.
+// The queue name must thus allow for at least that length with the
replacement of dots.
+var QueuePathRegExp = regexp.MustCompile(`^[a-zA-Z0-9_.:#/@-]{1,64}$`)
Review Comment:
Fix the comment, that is a copy-paste from `QueueNameRegExp`.
The maximum length of 64 is a bit too low, not sure what's a reasonable
limit here, I'd simply not validate the length of the path at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
