manirajv06 commented on code in PR #891:
URL: https://github.com/apache/yunikorn-core/pull/891#discussion_r1643947369
##########
pkg/scheduler/placement/fixed_rule.go:
##########
@@ -121,12 +121,19 @@ func (fr *fixedRule) placeApplication(app
*objects.Application, queueFn func(str
if parentName == "" {
parentName = configs.RootQueue
}
- queueName = parentName + configs.DOT + fr.queue
+ childQueueName := replaceDot(fr.queue)
+ if err = configs.IsQueueNameValid(childQueueName); err != nil {
+ return "", err
+ }
+ queueName = parentName + configs.DOT + childQueueName
Review Comment:
Yes, we should not replace dot in this rule.
https://issues.apache.org/jira/browse/YUNIKORN-2660 has been filed to make the
changes like you explained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
