wilfred-s commented on code in PR #891:
URL: https://github.com/apache/yunikorn-core/pull/891#discussion_r1639177674
##########
pkg/scheduler/placement/fixed_rule.go:
##########
@@ -121,12 +121,19 @@ func (fr *fixedRule) placeApplication(app
*objects.Application, queueFn func(str
if parentName == "" {
parentName = configs.RootQueue
}
- queueName = parentName + configs.DOT + fr.queue
+ childQueueName := replaceDot(fr.queue)
+ if err = configs.IsQueueNameValid(childQueueName); err != nil {
+ return "", err
+ }
+ queueName = parentName + configs.DOT + childQueueName
}
// Log the result before we check the create flag
log.Log(log.SchedApplication).Debug("Fixed rule intermediate result",
zap.String("application", app.ApplicationID),
zap.String("queue", queueName))
+ if err := configs.IsQueuePathValid(queueName); err != nil {
+ return "", err
+ }
Review Comment:
Did not repeat the comment for every rule this was part of.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
