chia7712 commented on code in PR #915:
URL: https://github.com/apache/yunikorn-core/pull/915#discussion_r1676508449
##########
pkg/common/security/usergroup_test_resolver.go:
##########
@@ -41,15 +41,19 @@ func GetUserGroupCacheTest() *UserGroupCache {
// test function only
func lookup(userName string) (*user.User, error) {
Review Comment:
This test offers the testing-only resolver to other test cases. Hence, could
you please move those constants to the beginning of file, and other tests
should share it instead of creating a bunch of "const"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
