chia7712 commented on code in PR #915:
URL: https://github.com/apache/yunikorn-core/pull/915#discussion_r1679962098
##########
pkg/webservice/handlers_test.go:
##########
@@ -840,10 +834,11 @@ func TestGetPartitionNodesUtilJSON(t *testing.T) {
// setup
partition := setup(t, configDefault, 1)
appID := "app1"
- node1ID := "node-1"
- node2ID := "node-2"
- node3ID := "node-3"
-
+ const (
Review Comment:
Could you reuse the solution used to fix `TestGetNodeUtilisation`?
##########
pkg/scheduler/tests/smoke_test.go:
##########
@@ -639,7 +640,9 @@ partitions:
err := ms.Init(configData, false, false)
assert.NilError(t, err, "RegisterResourceManager failed")
- leafName := "root.leaf"
+ const (
+ leafName = "root.leaf"
Review Comment:
we don't need it now, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
