chia7712 commented on code in PR #915:
URL: https://github.com/apache/yunikorn-core/pull/915#discussion_r1678373795
##########
pkg/scheduler/tests/smoke_test.go:
##########
@@ -46,6 +47,8 @@ partitions:
memory: 150M
vcore: 20
`
+ leafName = "root.singleleaf"
Review Comment:
Maybe we can align the naming by changing the "singleleaf" to "leaf". That
can work for all test cases. |
##########
pkg/scheduler/placement/provided_rule_test.go:
##########
@@ -119,7 +119,8 @@ partitions:
// unqualified queue with parent rule that exists directly in hierarchy
appInfo = newApplication("app1", "default", "testchild", user, tags,
nil, "")
queue, err = pr.placeApplication(appInfo, queueFunc)
- if queue != "root.testparent.testchild" || err != nil {
Review Comment:
any updates?
##########
pkg/scheduler/placement/rule.go:
##########
@@ -77,7 +77,8 @@ func (r *basicRule) getParent() rule {
//
//nolint:unused
func (r *basicRule) getName() string {
- return "unnamed rule"
+ const unnamedRuleName = "unnamed rule"
Review Comment:
Could you please put this const within a package ? That enables
`TestBasicRule` to use it to complete the validation.
##########
pkg/scheduler/placement/placement_test.go:
##########
@@ -260,7 +260,8 @@ partitions:
// user rule existing queue, acl allowed
err = man.PlaceApplication(app)
queueName := app.GetQueuePath()
- if err != nil || queueName != "root.testparent.testchild" {
+ const TestQueueName = "root.testparent.testchild"
Review Comment:
any updates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
