chia7712 commented on code in PR #915:
URL: https://github.com/apache/yunikorn-core/pull/915#discussion_r1682548048
##########
pkg/common/security/usergroup_test.go:
##########
@@ -88,9 +88,14 @@ func TestGetUserGroup(t *testing.T) {
testCache := GetUserGroupCache("test")
testCache.resetCache()
// test cache should be empty now
- assert.Equal(t, 0, testCache.getUGsize(), "Cache is not empty: %v",
testCache.getUGmap())
-
- ug, err := testCache.GetUserGroup("testuser1")
+ if len(testCache.ugs) != 0 {
Review Comment:
Why using this style? the origin assert is good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
