zhuqi-lucas commented on code in PR #943:
URL: https://github.com/apache/yunikorn-core/pull/943#discussion_r1716245423
##########
pkg/common/resources/resources.go:
##########
@@ -144,7 +144,20 @@ func (r *Resource) Clone() *Resource {
return ret
}
-// Add additional resource to the base updating the base resource
+// Prune removes any resource type that has a zero value set.
+// Note that a zero value set and a type not being set are interpreted
differently for quotas.
+func (r *Resource) Prune() {
Review Comment:
One question about the Prune, do we want to support other settings prune
besides the resource, for example:
When the maxapps is zero, do we want to prune it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
