wilfred-s commented on code in PR #943:
URL: https://github.com/apache/yunikorn-core/pull/943#discussion_r1716251421
##########
pkg/scheduler/objects/queue_test.go:
##########
@@ -1052,60 +1052,58 @@ func TestIsEmpty(t *testing.T) {
func TestGetOutstandingRequestMax(t *testing.T) {
// queue structure:
- // root
+ // root (max.cpu = 5)
Review Comment:
not really confusing: it is important to know what the root max is. What can
be accommodated by the root max is much lower than the outstanding requests
list returns clearly showing that it is irrelevant. That is also why I did not
set some strange high value but linked it to the fake allocation size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
