wilfred-s commented on code in PR #943:
URL: https://github.com/apache/yunikorn-core/pull/943#discussion_r1716347534
##########
pkg/scheduler/objects/queue_test.go:
##########
@@ -1176,10 +1173,11 @@ func TestGetOutstandingOnlyUntracked(t *testing.T) {
alloc, err := resources.NewResourceFromConf(map[string]string{"pods":
"1"})
assert.NilError(t, err, "failed to create basic resource")
var used *resources.Resource
- used, err = resources.NewResourceFromConf(map[string]string{"cpu":
"10", "pods": "10"})
+ usedMap := map[string]string{"cpu": "10", "pods": "10"}
+ used, err = resources.NewResourceFromConf(usedMap)
assert.NilError(t, err, "failed to create basic resource")
var root, queue1 *Queue
- root, err = createRootQueue(nil)
+ root, err = createRootQueue(usedMap)
Review Comment:
oh I understand now what you mean we need to update line 1166 with the root
size like we did in the other tests. Will add that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
