pbacsko commented on code in PR #1114:
URL: https://github.com/apache/yunikorn-core/pull/1114#discussion_r3681496451
##########
pkg/scheduler/objects/application_test.go:
##########
@@ -3340,6 +3340,52 @@ func TestTryAllocateWithReservedHeadRoomChecking(t
*testing.T) {
// reset wait timeout
}
+// TestTryReservedAllocateRequiredNodeNotCancelledOnTimeout verifies that
required node reservations
+// are not cancelled even if they exceed the reservationWaitTimeout.
+func TestTryReservedAllocateRequiredNodeNotCancelledOnTimeout(t *testing.T) {
+ setupUGM()
+ defer func() {
+ if r := recover(); r != nil {
+ t.Fatalf("reserved headroom test regression: %v", r)
+ }
+ }()
Review Comment:
Is this part needed? I don't think we need to recover from an assertion
panic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
