kaijaytu commented on code in PR #1114:
URL: https://github.com/apache/yunikorn-core/pull/1114#discussion_r3687708993
##########
pkg/scheduler/objects/application_test.go:
##########
@@ -3340,6 +3340,52 @@ func TestTryAllocateWithReservedHeadRoomChecking(t
*testing.T) {
// reset wait timeout
}
+// TestTryReservedAllocateRequiredNodeNotCancelledOnTimeout verifies that
required node reservations
+// are not cancelled even if they exceed the reservationWaitTimeout.
+func TestTryReservedAllocateRequiredNodeNotCancelledOnTimeout(t *testing.T) {
+ setupUGM()
+ defer func() {
+ if r := recover(); r != nil {
+ t.Fatalf("reserved headroom test regression: %v", r)
+ }
+ }()
Review Comment:
Good point--removed. That recover block was copied from the adjacent
TestTryAllocateWithReservedHeadRoomChecking and isn't needed. It appeared in
this PR because the branch was originally stacked on top of YUNIKORN-3320. The
PRs are now rebased independently, and the fix has been pushed to PR #1113
where the test lives.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
