kaijaytu opened a new pull request, #1114:
URL: https://github.com/apache/yunikorn-core/pull/1114
### Description
Fix `removeAsksInternal` return value being ignored in three callers,
causing the partition's reservation counter to not be decremented correctly:
- `partitionContext.removeApplication`: capture return value of
`RemoveAllocationAsk("")` and call `decReservationCount`
- `partitionContext.removeAllocation`: capture return value of
`RemoveAllocationAsk(allocationKey)` and call `decReservationCount`
- `timeoutPlaceholderProcessing`: add `reservationReleasedCallback`
(following the existing `terminatedCallback` pattern) so the async placeholder
timeout can notify the partition to decrement the reservation counter
Generated by GitHub Copilot (Claude)
### Type of change
- [x] Bug Fix
### Jira issue
Jira ID : https://issues.apache.org/jira/browse/YUNIKORN-3321
- [x] I have created a Jira issue for this pull request.
- [x] The Jira ID is part of the title of this pull request.
### AI Tooling
- [x] The PR includes the phrase "Generated by GitHub Copilot (Claude)",
where the tool is the name of the AI tool used.
- [x] My use of AI contributions follows the ASF legal policy.
### How has this been tested?
- [x] New unit tests were added to cover new or changed code paths.
- [x] `make test_all` was run, and no failures reported.
### Screenshots or other details
The fix ensures the partition reservation counter stays consistent when:
1. An application with active reservations is removed
2. An allocation with a reserved ask is released (non-timeout)
3. Placeholder timeout triggers removal of all pending asks that have
reservations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
