PoiBlackTea commented on PR #1064: URL: https://github.com/apache/yunikorn-k8shim/pull/1064#issuecomment-5315752003
> Should we not have the equivalent of the settings for the normal tests: > > ``` > test: export DEADLOCK_DETECTION_ENABLED = true > test: export DEADLOCK_TIMEOUT_SECONDS = 10 > test: export DEADLOCK_EXIT = true > ``` Hi @wilfred-s, thanks for the review! Just wanted to double check on the Makefile part: in e2e tests, YuniKorn runs inside the K8s cluster and gets the deadlock env vars via Helm in run-e2e-tests.sh. From what I can see, exporting DEADLOCK_* in make e2e_test would only affect the local Ginkgo runner (specifically the port-forward lock in k8s_utils.go). Just wanted to see if that's what you had in mind, or if I might have missed something. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
