chenyulin0719 commented on PR #1064: URL: https://github.com/apache/yunikorn-k8shim/pull/1064#issuecomment-5318264107
> From what I can see, exporting DEADLOCK_* in make e2e_test would only affect the local Ginkgo runner (specifically the port-forward lock in k8s_utils.go). Correct. And DEADLOCK_* to make e2e_test would be meaningless. What we really care about is whether the scheduler itself encounters deadlock. With another PR, the equivalent of deadlock detection settings are moved to the default value in helm chart. - https://github.com/apache/yunikorn-release/pull/237/changes#diff-9096e97495ff1a9082f744d0a08b7b33dd01025f0746d1b73710e4efbacf4980 Another way would be to add the equivalent flags to `run-e2e-tests.sh` ``` --set deadlockDetection.enabled=true \ --set deadlockDetection.timeoutSeconds=10 \ --set deadlockDetection.exit=true ``` Both is good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
