Reamer commented on code in PR #4730:
URL: https://github.com/apache/zeppelin/pull/4730#discussion_r1522774859
##########
jdbc/src/main/java/org/apache/zeppelin/jdbc/SqlCompleter.java:
##########
@@ -217,11 +217,11 @@ public static Set<String>
getSqlKeywordsCompletions(DatabaseMetaData meta) throw
Set<String> completions = new TreeSet<>();
if (null != meta) {
- // Add the driver specific SQL completions
- String driverSpecificKeywords =
- "/" + meta.getDriverName().replace(" ", "-").toLowerCase() +
"-sql.keywords";
- logger.info("JDBC DriverName:" + driverSpecificKeywords);
try {
+ // Add the driver specific SQL completions
+ String driverSpecificKeywords =
+ "/" + meta.getDriverName().replace(" ", "-").toLowerCase() +
"-sql.keywords";
+ logger.info("JDBC DriverName:" + driverSpecificKeywords);
Review Comment:
```suggestion
logger.info("JDBC DriverName: {}", driverSpecificKeywords);
```
##########
jdbc/src/main/java/org/apache/zeppelin/jdbc/SqlCompleter.java:
##########
@@ -217,11 +217,11 @@ public static Set<String>
getSqlKeywordsCompletions(DatabaseMetaData meta) throw
Set<String> completions = new TreeSet<>();
if (null != meta) {
Review Comment:
```suggestion
if (meta != null && meta.getDriverName() != null) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
