Reamer commented on code in PR #4730:
URL: https://github.com/apache/zeppelin/pull/4730#discussion_r1524560754
##########
jdbc/src/main/java/org/apache/zeppelin/jdbc/SqlCompleter.java:
##########
@@ -230,8 +230,7 @@ public static Set<String>
getSqlKeywordsCompletions(DatabaseMetaData meta) throw
keywords += "," + driverKeywords.toUpperCase();
}
} catch (Exception e) {
Review Comment:
We should catch the explicit exceptions. Also, `SQL-Exception` should be
removed as a throw declaration.
```suggestion
} catch (IOException | SQLException e) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
