Reamer commented on code in PR #4730:
URL: https://github.com/apache/zeppelin/pull/4730#discussion_r1522870539
##########
jdbc/src/main/java/org/apache/zeppelin/jdbc/SqlCompleter.java:
##########
@@ -217,11 +217,11 @@ public static Set<String>
getSqlKeywordsCompletions(DatabaseMetaData meta) throw
Set<String> completions = new TreeSet<>();
if (null != meta) {
Review Comment:
I see, therefore the additional null check `meta.getDriverName() != null`.
So the method should take the default keywords
```
String keywords =
new BufferedReader(new InputStreamReader(
SqlCompleter.class.getResourceAsStream("/ansi.sql.keywords"))).readLine();
```
and return this set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
