eunhwa99 opened a new pull request, #5048:
URL: https://github.com/apache/zeppelin/pull/5048
### What is this PR for?
This PR refactors the `StaticRepl` class to improve readability,
maintainability, and align with modern Java best practices.
There are no functional changes.
1. Generic type refinement with diamond operator in loop: Adds type safety
by explicitly specifying the generic type. Prevents unchecked warnings and
makes the code clearer to readers and tools.
2. Replace `Arrays.asList` to `List.of` : List.of (Java 9+) produces an
immutable list, which is safer and better communicates the intent that the list
will not be modified. It avoids side effects of Arrays.asList, which is
fixed-size and backed by the original array.
3. Minor typos fixed: Corrected spelling mistakes and adjusted comments.
4. Removes redundant boolean comparison to follow standard Java coding
conventions.
5. Replace index-based loop with enhanced for-each to eliminate boilerplate
index management, improves readability, and reduces chances of off-by-one
errors. It makes the intent ("iterate all elements") clearer.
6. Variable declaration moved closer to usage to improve code locality and
readability by reducing variable scope. This makes the code easier to maintain
and follow.
### What type of PR is it?
Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
* [ZEPPELIN-6299](https://issues.apache.org/jira/browse/ZEPPELIN-6299)
### How should this be tested?
* Run existing unit tests to confirm behavior remains unchanged.
### Screenshots (if appropriate)
### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
