ParkGyeongTae commented on code in PR #5048:
URL: https://github.com/apache/zeppelin/pull/5048#discussion_r2309886897
##########
java/src/main/java/org/apache/zeppelin/java/StaticRepl.java:
##########
@@ -104,14 +100,16 @@ public static String execute(String generatedClassName,
String code) throws Exce
System.setOut(newOut);
System.setErr(newErr);
+ JavaCompiler compiler = ToolProvider.getSystemJavaCompiler();
+ DiagnosticCollector<JavaFileObject> diagnostics = new
DiagnosticCollector<>();
Review Comment:
My personal opinion is that it would be good to throw an exception if
`JavaCompiler` is null.
I also think it would be better to handle this in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
