eunhwa99 commented on code in PR #5048:
URL: https://github.com/apache/zeppelin/pull/5048#discussion_r2309633994
##########
java/src/main/java/org/apache/zeppelin/java/StaticRepl.java:
##########
@@ -104,14 +100,16 @@ public static String execute(String generatedClassName,
String code) throws Exce
System.setOut(newOut);
System.setErr(newErr);
+ JavaCompiler compiler = ToolProvider.getSystemJavaCompiler();
+ DiagnosticCollector<JavaFileObject> diagnostics = new
DiagnosticCollector<>();
Review Comment:
Oh I see, thanks for the point!
Would it make sense to throw an exception here if JavaCompiler is null,
since running Java code requires a JDK?
Since this seems more related to functional stability, I feel it could be
handled in a separate PR. How do you feel about that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
