Sim IJskes - QCG wrote:
On 12-01-11 13:53, Peter wrote:
So what are you proposing exactly?
Are we talking making all methods protected or just the constructor?
Why is protected a better choice than public?
Uhm, while you were away, i've commited a few patches. So it's not a
proposal actually. It has more commitment. :)
The TransientRegistrarImpl has become public, the constructor
protected. As well as several other patches. Please view
river-commits@ for the details.
Gr. Sim
I've reviewed the changes, it would be more logical to add something
like adding a Factory to the same package or create a Discovery SPI or
some way to allow client code to use a local registrar without becoming
dependent on its implementation class, which would allow River to change
the implementation without breaking client code.
As I said before there are probably other uses for a pluggable local
registrar, in addition to embedded, so why not put the effort in and do
it properly? Or is there a deadline or something I'm unaware of?
Can you raise a JIRA, so I've got something for the release notes.
Peter.
