Comment #3 on issue 1495 by pekka.klarck: Add plain text syntax support
into ReST parser
http://code.google.com/p/robotframework/issues/detail?id=1495
After looking at the code a bit more closely I was happy to learn how
little new code was actually needed. The code isn't exactly complicated to
follow either, but I'd nevertheless like it to be cleaned up a little.
My main issue is that the RestReader class inherits from HtmlReader (like
it used to do earlier), but the new code delegates to TxtReader. This is
pretty inconsistent, and it would be better to use delegation in both
cases. I'd also like to see more helper methods used, at the moment the
read method is overly long and complicated.
Cleaning up the code is something I can easily do myself after applying and
committing the original patch. If you want to improve the code yourself, I
can provide more review comments.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
---
You received this message because you are subscribed to the Google Groups "robotframework-commit" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to robotframework-commit+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
