Comment #5 on issue 1495 by dataku...@gmail.com: Add plain text syntax support into ReST parser
http://code.google.com/p/robotframework/issues/detail?id=1495

Thank you a lot for review. A few quick responses and thoughts:

#2 Yes. Parsing robot syntax from .. code:: robotframework -direrctives requires Pygments (which now includes robotframework lexer). I tried to include check for that in test suite, similarly what was for docutils before. Probably there's a way to catch that warning and instruct the user better. The good thing in requiring Pygments is that no extra docutils-directives are needed and rest-files can be compiled without robotframework.

#3 Agreed. Good to know that also the old code should be refactored.

#4 Currently old style documents get parsed twice and that is a problem. While refactoring also the old code (for #3) it should be possible to use the same parsed doctree for fallback HTML-parser. After that the only overhead is the DFS for code-directives in the doctree and it should not be too bad. (Alternative could be to monkey patch code-directive in docutils in a way that already parsing the rst into a doctree finds all the relevant nodes, but that would not be as clean and monkeypatching would be a timebomb.)

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--

--- You received this message because you are subscribed to the Google Groups "robotframework-commit" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to robotframework-commit+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to