>> and realize that the maintainer of a package is - >> in the end - the one which sets the rule for it. Ergo, if you aren't >> create a pull request. > > This is what I mean. The maintainer ->must<- be among those with write > access to the repo, others ->have<- to use PRs anyways.
Others are *supposed to* follow whatever workflow the package maintainer and authors decided for this particular package. There are rules for rock core because all the rock users rely on it, but outside the core the individual package maintainers should IMO be free to decide which workflow works best for them. My point is: they're *supposed to*. There is nothing in github forbidding them to push to any repository inside the organization they are part of. > So maintainners can only be the guys who have write access, lets say for > rock-core, jacob thomas and you, all others can't be a maintainer, as they > cannot accept PRs at all. Look better, 6 people currently have write access to rock core. In addition, we're bootstrapping the list of maintainers. In the long run, you're probably right. In the short term, I am pretty sure that some of the package maintainers on github still don't have access to their repositories ... > The maintainer of an organisation can still delegate reviews of PR's to > others, but he is responsible for merging the PR in the end. So far, there was no such thing as a "maintainer of an organisation", only a maintainer of a package. This is what this discussion is all about: having people, for each package, that feels responsible for the maintenance of this particular package. > Or is the list you propose for you three to decide who should do the review? ??? Sylvain _______________________________________________ Rock-dev mailing list [email protected] http://www.dfki.de/mailman/cgi-bin/listinfo/rock-dev
