this is in line with the business layer cleanup work. here's a handful of manager methods that i would like to remove/modify ...

BookmarkManager:
getBookmarks(folder, subfolders) - move this into the folder pojo, like folder.getBookmarks(recursive)
getFolder(website, path) - ditch, not used
getPath(folder) - ditch, not really used and should just use folder.getPath() instead
isFolderInUse(folder) - ditch, not used
removeFolderContents(folder) - ditch, not used


UserManager:
getUsers(offset, length) - ditch, dupe of getUsers(enabled, start, end, offset, length)


WeblogManager:
getWeblogEntries(cat, subcats) - this could be considered a dupe of getWeblogEntries() and in principal this method is unrestrained by offset and length, which is a bad thing
getNextEntries(entry, cat, locale) - ditch, not used
getPreviousEntries(entry, cat, locale) - ditch, not used
getWeblogLastPublishTime(weblog) - ditch, not used

anyone object to these changes?

-- Allen

Reply via email to