On 11/15/06, Allen Gilliland <[EMAIL PROTECTED]> wrote:
this is in line with the business layer cleanup work. here's a handful
of manager methods that i would like to remove/modify ...
BookmarkManager:
getBookmarks(folder, subfolders) - move this into the folder pojo, like
folder.getBookmarks(recursive)
getFolder(website, path) - ditch, not used
getPath(folder) - ditch, not really used and should just use
folder.getPath() instead
isFolderInUse(folder) - ditch, not used
removeFolderContents(folder) - ditch, not used
UserManager:
getUsers(offset, length) - ditch, dupe of getUsers(enabled, start, end,
offset, length)
WeblogManager:
getWeblogEntries(cat, subcats) - this could be considered a dupe of
getWeblogEntries() and in principal this method is unrestrained by
offset and length, which is a bad thing
getNextEntries(entry, cat, locale) - ditch, not used
getPreviousEntries(entry, cat, locale) - ditch, not used
getWeblogLastPublishTime(weblog) - ditch, not used
anyone object to these changes?
Generally, no objection.
But are you certain the getPrevious and getNext methods are unused,
even in the deprecated rendering system? Seems like they were once
part of the next/prev control or the calendar?
- Dave
