On 1/24/07, Allen Gilliland <[EMAIL PROTECTED]> wrote:
these kinds of commits are going to start making me nervous now. granted that this is not a change that is likely to cause any real problems, but i don't think it's acceptable to be committing unnecessary changes to the code simply to work around issues with JDO/JPA. if something is broken then by all means fix it, but i don't think we want to hack at the code to work around implementation problems with the JDO/JPA backend.
Yes, I agree in general and understand that and am sensitive to your need for stability at this point. I only made that particular change because it's redundant, should be harmless and BSC doesn't use referrers.
this is only meant to serve as an example, i am not really objecting to this commit, but the other example is your comment about the websiteid column for the weblogcategory table. Craig had actually changed that column and committed it a while back and I had to revert that change because it's inappropriate, so I just want to say that we need to be careful about what is being committed.
Yeah, that's an unacceptable change and we need to figure out the underlying problem in the JPA code. - Dave
