Re: svn commit: r499420 - /incubator/roller/trunk/src/org/apache/roller/pojos/RefererData.java

[Allen Gilliland]

I agree, and in general any object which is associated with a specific 
weblog should probably be using the website in its equals() and 
hashCode() methods.  So maybe the what really needs to happen is to 
revert revision 499419 which removes those comparisons from the Folder 
and Category objects.

-- Allen

Mitesh Meswani wrote:
Hi Dave,

I don't think this is a workaround. At least during the test I came 
across instances of RefererData that belonged to different website but 
where refererUrl  was equal and weblogEntry was null. Is that not a 
probable scenario?

Regards,
Mitesh

[EMAIL PROTECTED] wrote:
Author: snoopdave
Date: Wed Jan 24 06:36:15 2007
New Revision: 499420

URL: http://svn.apache.org/viewvc?view=rev&rev=499420
Log:
Add website to equals() and hashCode(), which is redundant but allows 
us to work around a JPA issue.

Modified:
    incubator/roller/trunk/src/org/apache/roller/pojos/RefererData.java

Modified: 
incubator/roller/trunk/src/org/apache/roller/pojos/RefererData.java
URL: 
http://svn.apache.org/viewvc/incubator/roller/trunk/src/org/apache/roller/pojos/RefererData.java?view=diff&rev=499420&r1=499419&r2=499420 

============================================================================== 

--- 
incubator/roller/trunk/src/org/apache/roller/pojos/RefererData.java 
(original)
+++ 
incubator/roller/trunk/src/org/apache/roller/pojos/RefererData.java 
Wed Jan 24 06:36:15 2007
@@ -438,6 +438,7 @@
         return new EqualsBuilder()
             .append(getRefererUrl(), o.getRefererUrl())              
.append(getWeblogEntry(), o.getWeblogEntry()) +            
.append(getWebsite(),o.getWebsite())
             .isEquals();
     }
     @@ -445,6 +446,7 @@
         return new HashCodeBuilder()
             .append(getRefererUrl())
             .append(getWeblogEntry())
+            .append(getWebsite())
             .toHashCode();
     }