On 2009-12-11, at 10:10 AM, Love Nystrom wrote: > Alex Ionescu wrote: >> There is a reason this set and names was chosen, please don't change them. >> It is for SDK compatibility. >> > > I see mostly additions that reflect Intel flag identifiers.. ergo, no > major panic.
I created the NDK -- who are you to comment on whether or not I should panic? These changes are wrong. > None of the EFLAGS_xx show up in my public MS headers, which must mean > that they are inofficial identifiers only known to priviledged devs. LOL! Reminds me of an argument I had a couple of days ago: "I never heard of HGH being added to foods in the US, so it must not be true". Tell me, did you download ALL the Microsoft headers? ALL of them? Do you even know where to get them all? Do you have, for example, the WMP 11 SDK? Or the ADAM SDK? Why would ReactOS developers be using "inofficial" headers? What's a "privileged" developer? I just LOVE the "I can't find these definitions in some arbitrary set of headers I somehow obtained, so they must not exist" argument. > Ergo, we may define them to correctly reflect the EFLAGS register. Who is "WE"? You're not even a DEV for this project! > > However, but I think Alex is right that the compatible identifiers > should be retained. > EFLAG_SIGN and EFLAG_ZERO are used to compare flags in AH after LAHF, > and should be retained verbatim, since they are public (in NTDDK.H). > As for any MS EFLAGS_xx definitions, I'm not privvy and can't say. Then shut up and don't post completely USELESS and wrong information. > > Best Regards // L > >> On 2009-12-10, at 3:22 PM, [email protected] wrote: >>> Author: tkreuzer >>> Date: Thu Dec 10 02:44:42 2009 >>> New Revision: 44508 >>> >>> URL: http://svn.reactos.org/svn/reactos?rev=44508&view=rev >>> Log: >>> updates EFLAGS definitions >>> >>> Modified: >>> branches/ros-amd64-bringup/reactos/include/ndk/amd64/ketypes.h >>> >>> Modified: branches/ros-amd64-bringup/reactos/include/ndk/amd64/ketypes.h >>> URL: >>> http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/include/ndk/amd64/ketypes.h?rev=44508&r1=44507&r2=44508&view=diff >>> ============================================================================== >>> --- branches/ros-amd64-bringup/reactos/include/ndk/amd64/ketypes.h >>> [iso-8859-1] (original) >>> +++ branches/ros-amd64-bringup/reactos/include/ndk/amd64/ketypes.h >>> [iso-8859-1] Thu Dec 10 02:44:42 2009 >>> @@ -82,19 +82,24 @@ >>> // >>> // EFlags >>> // >>> -#define EFLAGS_CF 0x01L >>> -#define EFLAGS_ZF 0x40L >>> -#define EFLAGS_TF 0x100L >>> -#define EFLAGS_INTERRUPT_MASK 0x200L >>> -#define EFLAGS_DF 0x400L >>> -#define EFLAGS_NESTED_TASK 0x4000L >>> -#define EFLAGS_V86_MASK 0x20000 >>> +#define EFLAGS_CF 0x01 >>> +#define EFLAGS_PF 0x04 >>> +#define EFLAGS_AF 0x10 >>> +#define EFLAGS_ZF 0x40 >>> +#define EFLAGS_SF 0x80 >>> +#define EFLAGS_TF 0x100 >>> +#define EFLAGS_INTERRUPT_MASK 0x200 >>> +#define EFLAGS_DF 0x400 >>> +#define EFLAGS_OF 0x800 >>> +#define EFLAGS_IOPL_MASK 0x3000 >>> +#define EFLAGS_NESTED_TASK 0x4000 >>> +#define EFLAGS_RF 0x10000 >>> +#define EFLAGS_VM 0x20000 >>> #define EFLAGS_ALIGN_CHECK 0x40000 >>> #define EFLAGS_VIF 0x80000 >>> #define EFLAGS_VIP 0x100000 >>> +#define EFLAGS_ID 0x200000 >>> #define EFLAGS_USER_SANITIZE 0x3F4DD7 >>> -#define EFLAG_SIGN 0x8000 >>> -#define EFLAG_ZERO 0x4000 >>> >>> // >>> // IPI Types >> Best regards, >> Alex Ionescu > > _______________________________________________ > Ros-dev mailing list > [email protected] > http://www.reactos.org/mailman/listinfo/ros-dev Best regards, Alex Ionescu _______________________________________________ Ros-dev mailing list [email protected] http://www.reactos.org/mailman/listinfo/ros-dev
