Alex Ionescu wrote: > 1) Assembly code can't access winddk.h > True, but this was ketypes.h, not asm.h!
> 2) They are in ks386.inc so they must be in asm.h (PSDK compat) > So you fucked it up in the first place. :-P >> 2.) added EFLAGS_PF, EFLAGS_AF, EFLAGS_SF, EFLAGS_OF, EFLAGS_IOPL_MASK, >> EFLAGS_RF, EFLAGS_ID just for completeness. >> > > Problem is these aren't in ks386.inc -- hence we lose PSDK compat. Put them > in an internal ntoskrnl header or something. > Ok, will do. >> The rest is still the same, although these definitions don't match >> ksasm64.inc >> > > That's the problem! > They haven't been correct before this commit. And They are also not identical to ks386.inc, as far as I can see. > The real problem is asm.h needs to be 100% compatible with ks386.inc and > moved to include/psdk. > > Anything that was used in asm.h and is not in ks386.inc needs to go to some > internal header. > Ok, I will create such a header. I suggest to rename the files to ks386.h and ksamd64.h instead of asm.h and instead create include/reactos/i386/asm.h containing additional _______________________________________________ Ros-dev mailing list [email protected] http://www.reactos.org/mailman/listinfo/ros-dev
