The branch version has 99% comments changes (// versus ;), #define versus equ at the top for the constants, and the last change is to tell gas its using intel syntax.
Almost the entire tree is built using gas, hence the change. Kind regards, Sylvain Petreolle ----- Message d'origine ---- > De : Brian Palmer <[email protected]> > À : ReactOS Development List <[email protected]> > Envoyé le : Mar 7 septembre 2010, 19h 12min 34s > Objet : Re: [ros-dev] Re : [ros-diffs] [akhaldi] 48687: [FREELDR] >-Convertfat12/16 boot secto > > > Since fathelp was already in Intel syntax originally, why did we require a > new version from another branch? What was changed? > > -----Original Message----- > From: [email protected] [mailto:[email protected]] On > Behalf Of Sylvain Petreolle > Sent: Friday, September 03, 2010 8:50 AM > To: ReactOS Development List > Subject: [ros-dev] Re : [ros-diffs] [akhaldi] 48687: [FREELDR] > -Convertfat12/16 boot secto > > It has already been addressed : > Next commit replaced fathelp by the intel syntax version from amd64 branch, > written by Timo. > No code style change was required by this, no new bugs. > Kind regards, > Sylvain Petreolle > > > > ----- Message d'origine ---- > > De : Pierre Schweitzer <[email protected]> > > À : ReactOS Development List <[email protected]> > > Envoyé le : Ven 3 septembre 2010, 12h 50min 59s > > Objet : Re: [ros-dev] [ros-diffs] [akhaldi] 48687: [FREELDR] > -Convertfat12/16 > >boot secto > > > > Pushing the question (which was the real question in Ionescu's mail...). > >http://www.redhat.com/docs/manuals/enterprise/RHEL-3-Manual/gnu-assembler/i > 386-syntax.html > >l > > > > Best regards, > > Pierre > > > > PS: Nice to see you back Alex ;). > > > > > What was the reason for the change? > > > It would be preferable to keep everything in intel syntax. Especially > as > > > this is an NT OS. > > > > > > It should also be noted that this is in a branch, not trunk. > > > > > > Ged. > > > > > > > > > -----Original Message----- > > > From: [email protected] [mailto:[email protected]] > On > > > Behalf Of Aleksey Bragin > > > Sent: 02 September 2010 21:55 > > > To: ReactOS Development List > > > Subject: Re: [ros-dev] [ros-diffs] [akhaldi] 48687: [FREELDR] - Convert > > > fat12/16 boot sector helper code to gas syntax. Brought to you by the > Arty. > > > [CMAKE] - Add freeldr and setupldr to build. > > > > > > I'm anti-AT&T syntax guy too :) > > > > > > WBR, > > > Aleksey. > > > > > > P.S. Nice to see Alex's post here, in his good old style. > > > > > > -------------------------------------------------- > > > From: "Daniel Reimer" <[email protected]> > > > Sent: Thursday, September 02, 2010 11:33 PM > > > To: "ReactOS Development List" <[email protected]> > > > Subject: Re: [ros-dev] [ros-diffs] [akhaldi] 48687: [FREELDR] - Convert > > > > fat12/16 boot sector helper code to gas syntax. Brought to you by the > Arty. > > > > [CMAKE] - Add freeldr and setupldr to build. > > > > > > > Err, nice to call ppl idiots who try to get the project further... > > > > > > > > If there are bugs, feel free to fix them... > > > > > > > > > > > > Am 02.09.2010 21:17, schrieb Alex Ionescu: > > > >> This is retarded, GAS supports Intel syntax. Why did this require > > > >> rewriting everything in AT&T syntax and introducing bugs? And what's > > > >> up with calling AT&T syntax "GAS" Syntax. > > > >> > > > >> I wonder what Brian would say.... > > > >> > > > >> It's funny how this project gets rid of old developers, gets new > > > >> developers, and has them make the same mistakes/idiotic things the > old > > > >> developers left for in the first place... > > > >> > > > >> Good job! > > > >> > > > >> Best regards, > > > >> Alex Ionescu > > > > > > > > > _______________________________________________ > > > Ros-dev mailing list > > > [email protected] > > > http://www.reactos.org/mailman/listinfo/ros-dev > > > > > > > > > _______________________________________________ > > > Ros-dev mailing list > > > [email protected] > > > http://www.reactos.org/mailman/listinfo/ros-dev > > > > > > > > _______________________________________________ > > Ros-dev mailing list > > [email protected] > > http://www.reactos.org/mailman/listinfo/ros-dev > > > > _______________________________________________ > Ros-dev mailing list > [email protected] > http://www.reactos.org/mailman/listinfo/ros-dev > > > _______________________________________________ > Ros-dev mailing list > [email protected] > http://www.reactos.org/mailman/listinfo/ros-dev > _______________________________________________ Ros-dev mailing list [email protected] http://www.reactos.org/mailman/listinfo/ros-dev
