On Saturday 07 June 2003 02:17 pm, Chris Cannam wrote:
> On Saturday 07 Jun 2003 6:45 pm, Guillaume Laurent wrote:
> > On Saturday 07 June 2003 14:00, Levi Burton wrote:
> > > So, basically checking every assumption that *pointer is not null
> > > with an assert().  I am guessing thats a shit-load of work.
>
> I think most of the work is in finding the places where it would
> actually make sense to assert

Yes, I definitely agree there, which was why I started this thread to begin 
with.  And, it should be pretty obvious I have never actually used assert() 
in anything non-trivial.  

> Asserts are handy in some circumstances, but they're more something
> you write as you write the code than something you work to add
> afterwards.  And they can cause problems -- I have twice recently had
> to remove asserts because they were causing crashes in cases where
> the assumption they were testing was not in fact true any more (i.e.
> a null value was actually acceptable, or whatever).

This is insight I was hoping to gain.  Again, my lack of experience shows 
here.

> > I don't mean to
> > brag but I agree with Rich, given our features list our stability
> > is fairly good.
>
> Given that this thread was inspired by a comment of mine about how our
> code could use some improvement, I think the subject is certainly
> fair game.  I just don't think assert is quite the answer.

Oh, and I just wanted to add that rosegarden seems much more robust than when 
I last hacked on it a few months ago.  I didn't mean to ruffle any feathers 
with my opening comment about crashes -- sometimes I don't think before I 
type (in other words, I should have respected the fact you are well aware of 
bugs).

Anyway, thanks!

-- 
Levi Burton
http://www.puresimplicity.net/~ldb/



-------------------------------------------------------
This SF.net email is sponsored by:  Etnus, makers of TotalView, The best
thread debugger on the planet. Designed with thread debugging features
you've never dreamed of, try TotalView 6 free at www.etnus.com.
_______________________________________________
Rosegarden-devel mailing list
[EMAIL PROTECTED] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

Reply via email to