On Sunday 11 December 2005 07:30 pm, Stephen Torri wrote:
> I am a bit fuzzy on who had a laundry list of things to be done to the
> guitar chord editor. I would appreciate that list on Thursday. My finals
> end on Wednesday so in between now and then I am, well, busy.

I never wrote it out, did I?  I was just going to go fix some of it, but you 
seem to want the learning experience as much as anything, so have at it.

* Your dialog needs some layout work.  I can't see all of its buttons, and 
it's not possible to make them appear by resizing it.  I haven't looked at 
your code at all, but the end user result is that it looks like the same kind 
of my problem *my* first dialog had.  I based mine around some 
Designer-generated code that used all kinds of spacers and other hacky 
whatnot.  It looked fine to me, but not to someone with a different KDE 
widget set or a different screen resolution or whatever.  Guillaume threw all 
of that away and redid the layout correctly.  You might look at eventfilter.* 
as a model for the right sort of layout.

* This is *not* tablature.  None of this has anything to do with tablature at 
all.  It shouldn't be called "Guitar Tab Editor" because it *isn't* a guitar 
tab editor.  I thought we hashed that out before.  Perhaps call it "Guitar 
Chord Diagram Editor."

* If a chord doesn't start at the nut, the fret number at the top right of the 
diagram that's printed on the notation editor screen does not display 
correctly.  Instead of a 7, I got a / shape, for example.

* I can't figure out any way to lay out the chords so that there's one chord 
per note.  One chord per note comes up in half the songs in my patented "Ye 
Olde Not Very Goode Christmas Fake Book" for instance.  I should be able to 
associate any number of chords with any number of notes in the melody line, 
and the spacing of the measure should be able to expand to accommodate this 
as necessary.  Currently I can only get two chords over a measure, and it's 
not clear which of four notes in 4/4 time they are supposed to be attached 
to.

* I ran into a really ugly race condition that bogged down my whole machine 
with thhhhhhhhousands of messages like "String number 3332288 is greater than 
six.  String number 3332289 is greater than six.  number 3332290, 3332291, 
etc. etc. etc."  I don't have an exact copy of the error, and I don't 
remember how I got there, but it was complete insanity.  Whatever error 
checking that is needs some sanity check on it, so that after the first 
greater than six it stops incrementing whatever counter was going completely 
amok and just barfs discretely, and as politely as possible.

That's all I can think of at the moment, but I think that's the bulk of the 
"laundry list" anyway.  Mostly pretty trivial nitpick stuff.  I've built up 
some real enthusiasm for your work now, and I look forward to bringing this 
feature to fruition.  It's going to be pretty cool!


-- 
D. Michael 'Silvan' McIntyre  ----   Silvan <[EMAIL PROTECTED]>
Linux fanatic, and certified Geek;  registered Linux user #243621

Author of Rosegarden Companion http://rosegarden.sourceforge.net/tutorial/


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Rosegarden-devel mailing list
[email protected] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

Reply via email to