On Monday 12 December 2005 01:30, Stephen Torri wrote: > I am a bit fuzzy on who had a laundry list of things to be done to the > guitar chord editor. I would appreciate that list on Thursday. My finals
Better late than never, here's mine (after an update of your branch). Most are details (but then again that's where the devil lies :-) ). The chord editor : - some layout nitpicks : buttons on the right look too big, I'd stack them on the bottom of the dialog. It's also probably better to disallow resizing of the dialog. - the scale names with "_Sharp" or "_Flat" would look much better with actual '#' and 'b'. - I'm not sure the scrollbar is the right control to select the fret number of the fingering, a spinbox would probably be more appropriate, and strange things sometimes happen when you set open strings along with a barré, and then use that scrollbar. - the fingering editor itself still needs work. There is no way to remove a dot (except by adding one on another fret on the same string). When "drawing" a barré, there's no visual feedback of the mouse move. It lets you add a dot (and even a muted or an open string) *behind* a barré. - it's possible that eventually you'll have to support custom tunings, but I wouldn't worry about it for now. - I'm not at all comfortable with the Scale/Modifier/Suffix representation of a chord. That's my biggest gripe. I'm sorry if this was already discussed and I glanced over it, but as a guitar player this really doesn't make sense to me. A chord should be defined with a tonic, an "extension" (can't find a better term), and an altered bass. For instance with your current scheme I don't see how I can make the distinction between a C7 and a Cmaj7. Also, it doesn't make sense to let one add any kind of "suffix" after a 'sus' (only sus2 and sus4 exist) or a 'dim' (only dim or dim7). It lacks 'add' (Cadd9, Cadd11 - or is that 'plus' ?), and finally you can add only one modifier while in practice you can have two (C7sus4, C6/9, Cmaj7#5). I suggest you take a look at a chord dictionnary before going on, I found this one to be rather good : http://www.jmdl.com/howard/guitarchords/C_chords.html About the chord selector : - apparently some of the fingerings are wrong, and some are missing, like the A form for C major (x13330). - same comment about the buttons than with the chord editor, layout probably needs some rethinking, the aliases field is probably too large too - 'Create' should be 'New' I think That's about it. The chords display nicely over notation, which is probably the hardest part to get right, so I wouldn't worry too much about the rest. :-) -- Guillaume. http://www.telegraph-road.org ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_idv37&alloc_id865&op=click _______________________________________________ Rosegarden-devel mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
