On Mon, 2005-12-12 at 22:57 -0500, D. Michael 'Silvan' McIntyre wrote:
> * Your dialog needs some layout work.  I can't see all of its buttons, and 
> it's not possible to make them appear by resizing it.  I haven't looked at 
> your code at all, but the end user result is that it looks like the same kind 
> of my problem *my* first dialog had.  I based mine around some 
> Designer-generated code that used all kinds of spacers and other hacky 
> whatnot.  It looked fine to me, but not to someone with a different KDE 
> widget set or a different screen resolution or whatever.  Guillaume threw all 
> of that away and redid the layout correctly.  You might look at eventfilter.* 
> as a model for the right sort of layout.

Fixed in cvs. I believe this layout is better.

> * This is *not* tablature.  None of this has anything to do with tablature at 
> all.  It shouldn't be called "Guitar Tab Editor" because it *isn't* a guitar 
> tab editor.  I thought we hashed that out before.  Perhaps call it "Guitar 
> Chord Diagram Editor."

Double check me but I think I relabeled things right.

> * If a chord doesn't start at the nut, the fret number at the top right of 
> the 
> diagram that's printed on the notation editor screen does not display 
> correctly.  Instead of a 7, I got a / shape, for example.

This goes back to the font issue you mentioned that plagues everything
in rosegarden. If too large a font is used numbers will be displayed but
appear cutoff.

> * I can't figure out any way to lay out the chords so that there's one chord 
> per note.  One chord per note comes up in half the songs in my patented "Ye 
> Olde Not Very Goode Christmas Fake Book" for instance.  I should be able to 
> associate any number of chords with any number of notes in the melody line, 
> and the spacing of the measure should be able to expand to accommodate this 
> as necessary.  Currently I can only get two chords over a measure, and it's 
> not clear which of four notes in 4/4 time they are supposed to be attached 
> to.

This is another item I could use some help on. A chord should be movable
to any place. What Silvan called micro-positioning. Any suggestions on
this?

> * I ran into a really ugly race condition that bogged down my whole machine 
> with thhhhhhhhousands of messages like "String number 3332288 is greater than 
> six.  String number 3332289 is greater than six.  number 3332290, 3332291, 
> etc. etc. etc."  I don't have an exact copy of the error, and I don't 
> remember how I got there, but it was complete insanity.  Whatever error 
> checking that is needs some sanity check on it, so that after the first 
> greater than six it stops incrementing whatever counter was going completely 
> amok and just barfs discretely, and as politely as possible.

Fixed in cvs. Failed to send a pointer to an allocated Barre object
rather than to a Barre object on the stack.

Stephen

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to