On Saturday 23 September 2006 7:58 am, Chris Cannam wrote: > OK, no objections, so we'll perhaps try to get started on this > reorganisation during the coming week.
Huh? Oh. Yeah, yeah, it looked fine to me Chris. I just never got around to saying so. Things are going badly at work. I'm not getting the new job, and all I managed to accomplish in the attempt is to get everything stirred up to a point where I can no longer stand my current job either. Bleck. > This will take quite a bit of work, I'm afraid, and I'd like to be able > to parcel out individual directories to various people to do "fix-ups". > > This should principally mean adding any includes, declarations etc that > the automated scripts have missed -- a sort of repetitive trial and > error process that ends when all the files in the directory actually > compile. Please let me know if you think you'll have a bit of time > around the end of this week. I have a bit of time right now. I'm not going out Sunday, as a bit of a lame consolation prize. The weather is crap crap crappy, and there's nothing to do but stay in here. > * All files renamed to .h/.cpp (i.e. no more .C files) About frickin' time on that one. > * Command class names will lose any contextual prefix (e.g. the > name of the menu the command is used in, which I should never > have encoded into the name of the command but did, for several) That too. But what about duplicated commands? Like NotesAdjustMenuFooBarCommand() and MatrixAdjustMenuFooBarCommand(). Sometimes they were block copied wholesale from one *commands* file to the other, and sometimes they had to be doctored up a little or a lot. That's got a lot of potential to be ugly. Especially if the commands have the same name once the menu context is stripped away. While we're at it though, if LaunchTheEventFilterCommand() could be used in exactly the same way by three different views, we could use just one copy of the code, in one place, without all the senseless duplication. So the net result is that we probably stand to clean up a really nasty tangle of brambles on all that. > * Indentation will be Java-style, 4 spaces at a time, no tabs That three. We *still* have problems with tabs. I'll be happy to set vim to always uses spaces and say to hell with tabs forever. > Any more thoughts welcome. This all sounds like one bastard of a slog, but worth doing, so let's roll up our sleeves and get this the hell over with as soon as possible. -- D. Michael McIntyre Linux fanatic, and certified Geek; registered Linux user #243621 Author of Rosegarden Companion http://rosegarden.sourceforge.net/tutorial/ ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Rosegarden-devel mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
