Chris (no ambiguity if I call you that -- and I'm used to being surrounded by other Chris's at work),
Thanks for the patch. I've just looked over it and it looks mostly fine -- a couple of minor comments though -- just to prove that I've read it... First, it introduces a couple of qstrtostr(strtoqstr(...)), which is a no-op -- this just means that the original strtoqstr() call was introduced in error. (There are some discrepancies in different builds of the Qt libraries in terms of what sort of string conversions they will support silently, so these errors are not always spotted by us or other users with mainstream distro builds.) Second, the patch contains two supposed additions (to MatrixView and LilyPondExporter) that are actually already present in the Rosegarden code in SVN. Any idea how that happened? In this particular case it wouldn't actually matter -- patch would reject these changes, probably -- but I'd like to be sure this isn't a symptom of a genuine problem with generating the patch. Chris ------------------------------------------------------------------------------ _______________________________________________ Rosegarden-devel mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
