On 09/02/2013 01:51 AM, Niek van den Berg wrote:

> With this patch Text::Chord becomes transposable by adding transpose() methods
> to the class ChordLabel. Also this class now has a new constructor which takes
> a chord as a string (like C, Dm, F7/D) and parses this string.

Lots of interesting work here, Niek.  My first reaction is to wonder how 
this can translate into languages that don't use ABCDEFG letter names (a 
lot of them).  In testing that, I found some crashes, and got completely 
distracted.

I'm going to revert your patch and go after the crashes, which are 
probably not related.  Then I will reapply your patch and take a look at 
the translation problem.
-- 
D. Michael McIntyre

------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

Reply via email to