On 2/18/22 2:38 PM, Philip Leishman wrote:

Very mysterious !!!

Yes indeed.


You should see in the code:
in data/rc/matrix.rc - the definition of the menu:

<Menu name="Highlight">
       <text>&amp;Highlight</text>
       <Action name="highlight_black_notes" text="Highlight black notes"
checked="false" />
       <Action name="highlight_triads" text="Highlight triads"
checked="false" />
</Menu>

and in src/gui/editors/matrix/MatrixView.cpp - the creation of the actions:

     createAction("show_note_names", SLOT(slotShowNames()));
     createAction("highlight_black_notes", SLOT(slotHighlight()));
     createAction("highlight_triads", SLOT(slotHighlight()));
     // add the highlight actions to an ActionGroup
     QActionGroup *ag = new QActionGroup(this);
     ag->addAction(findAction("highlight_black_notes"));
     ag->addAction(findAction("highlight_triads"));

Seems the same in the sources I have.


The only thing a bit unusual is the QActionGroup.
Another place this is used is in the notation editor - Can you see the
note font and size menu items at the top of the view menu ?

Yes. I guess that makes it even worse (why working there and not in Matrix Editor)?


Something to do with Qt version: 5.9.7 ???

Only thing I found in a quick comparison between:
    https://doc.qt.io/qt-5/qactiongroup.html
    https://doc.qt.io/archives/qt-5.9/qactiongroup.html
is that the 5.9 docs explicitly state that QActionGroup inherits objectName from QObject vs current (5.15??) which doesn't mention it. Must be a change in the documentation style because they both inherit QObject.


Very strange

Sigh, yes. I'll keep working on it. BTW, I also did the following, but I'm guessing none of the tests check GUI correctness (very difficult to do) much less this specific case.

$ make clean
$ cmake .. -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON
$ make
$ make test
Running tests...
Test project /usr/local/x/rosegarden/unbacked/21.12/rosegarden-git/build
      Start  1: realtime
 1/10 Test  #1: realtime .........................   Passed    0.03 sec
      Start  2: accidentals
 2/10 Test  #2: accidentals ......................   Passed    0.02 sec
      Start  3: segmenttransposecommand
 3/10 Test  #3: segmenttransposecommand ..........   Passed    0.02 sec
      Start  4: test_notationview_selection
 4/10 Test  #4: test_notationview_selection ......   Passed    1.04 sec
      Start  5: transpose
 5/10 Test  #5: transpose ........................   Passed    0.02 sec
      Start  6: reference_segment
 6/10 Test  #6: reference_segment ................   Passed    0.02 sec
      Start  7: utf8
 7/10 Test  #7: utf8 .............................   Passed    0.02 sec
      Start  8: testmisc
 8/10 Test  #8: testmisc .........................   Passed    0.91 sec
      Start  9: convert
 9/10 Test  #9: convert ..........................   Passed    0.51 sec
      Start 10: lilypond_export_test
10/10 Test #10: lilypond_export_test .............   Passed    5.12 sec

100% tests passed, 0 tests failed out of 10

Total Test time (real) =   7.72 sec


_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

Reply via email to