As per my other thread, I'm about to attempt some changes to the
Rosegarden codebase and have a question that isn't covered in
https://www.rosegardenmusic.com/wiki/dev:coding_style.
I use my own custom Emacs mode for editing source code. When opening
files it changes spaces to 4-character-wide tabs, and when writing them
out converts those back to the appropriate space (ascii 0x20)
characters. The wiki states "There should be no tab characters (0x09)
anywhere". That's always been my philosophy, too. Great minds think
alike. ;) So any file I edit that does have illegal tab characters
won't have them after I'm done with it. I guessing shouldn't be too
controversial (the tabs weren't supposed to be there in the first place).
What might be objectionable is that my Emacs also strips out any
trailing spaces on lines that have them. I've found a fair number of
these in the Rosegarden sources, including otherwise blank lines that
only have spaces (indents to nowhere).
Could someone (Ted?) make an executive-level decision on how I should
handle this? I'm guessing it will be something like:
1) "Hey, we're cool with it. Removing the extraneous spaces slightly
improves the code."
2) "Hmmm, grumble, OK. But first commit each file with just the
whitespace changes so we can run git-diff (diff, kompare, meld,
whatever) without seeing spurious changes or having to add the "-w"
commandline option."
3) "Absolutely not! You shouldn't be touching any lines you don't have
to and changing the code unnecessarily."
4) "Get out of here and stop bothering us with your crap code and
incessant questions." ;)
Thanks for any feedback. I want to be as good a Rosegarden
developer/citizen as I possibly can. Even though removing the extra
whitespace is obviously the right thing to do. ;)
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
