On 2/20/22 4:03 PM, mark_at_yahoo via Rosegarden-devel wrote:
Could someone (Ted?) make an executive-level decision on how I should handle this? I'm guessing it will be something like:

1) "Hey, we're cool with it. Removing the extraneous spaces slightly improves the code."

  If you are in there, fix it.  If you aren't, leave it alone.

2) "Hmmm, grumble, OK. But first commit each file with just the whitespace changes so we can run git-diff (diff, kompare, meld, whatever) without seeing spurious changes or having to add the "-w" commandline option."

This sounds good. That way we don't have to look at whitespace issues when bisecting to find problems.

3) "Absolutely not! You shouldn't be touching any lines you don't have to and changing the code unnecessarily."

Again, just the files you are doing work on. Leave the rest alone. Want to keep git blame as relevant as possible in case we need it.

4) "Get out of here and stop bothering us with your crap code and incessant questions." ;)

No. Bring on the code. I can't promise very fast turnaround (we have two top priority user requests in play right now), but I will get to it. If you can get someone else on the team reviewing and testing, that would help me immensely. I need two sets of eyes on every change at the user and developer levels.

Ted.


_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

Reply via email to