pmatilai commented on this pull request.


> @@ -238,11 +239,25 @@ static rpmtd makeSigTag(Header sigh, int ishdr, uint8_t 
> *pkt, size_t pktlen)
     return sigtd;
 }
 
+static pid_t gpgPid = 0;

Okay, thinking about it with hopefully somewhat fresher head, I suppose this 
should be `volatile` in addition to being static. As SIGCHLD is the only 
registered signal for that it can't be called multiple times so atomicity 
issues shouldn't come to play. And now my head hurts :smile: 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/938#pullrequestreview-323605958
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to